-
Notifications
You must be signed in to change notification settings - Fork 296
Support Update join #761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lxfeng1997
wants to merge
14
commits into
apache:master
Choose a base branch
from
lxfeng1997:update_join
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+685
−3
Open
Support Update join #761
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
4660a11
暂存
lxfeng1997 1340fb4
Merge branch 'master' into update_join
lxfeng1997 e430bc6
duplicate image row for update join
lxfeng1997 63678ce
update join condition placeholder param error
lxfeng1997 85de238
update join bugfix
lxfeng1997 cacae21
Open test annotations
lxfeng1997 be59040
Merge branch 'master' into update_join
lxfeng1997 0774046
recover update executor
lxfeng1997 a5a1955
recover update test
lxfeng1997 adabe14
recover update test
lxfeng1997 e08052c
Merge branch 'master' into update_join
luky116 357571d
Merge branch 'master' into update_join
Code-Fight 61c6b1b
Merge branch 'master' into update_join
luky116 530509a
Merge branch 'master' into update_join
Code-Fight File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -244,6 +244,10 @@ func (c *Conn) BeginTx(ctx context.Context, opts driver.TxOptions) (driver.Tx, e | |
) | ||
} | ||
|
||
func (c *Conn) GetDbVersion() string { | ||
return c.res.GetDbVersion() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe 'c.res' was nil? |
||
} | ||
|
||
func (c *Conn) GetAutoCommit() bool { | ||
return c.autoCommit | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个有需要支持吗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我认为是需要支持的,不过或许可以提另外的issues分开去做?