HttpServiceTaskState Support #769
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
luky116
reviewed
Feb 15, 2025
xjlgod
reviewed
Mar 1, 2025
| } | ||
|
|
||
| type HTTPClientImpl struct { | ||
| serviceName string |
There was a problem hiding this comment.
Should we consider the case where a client can access multiple urls
There was a problem hiding this comment.
Should we consider the case where a client can access multiple urls
Could you describe a specific scenario?
There was a problem hiding this comment.
I think there are many interfaces that could be called under a service, such as the inventory service that could query and modify inventory. But it seems that this design is not necessary here
There was a problem hiding this comment.
Maybe a client should be able to call multiple interfaces under a service？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
HttpServiceTaskState Support #730
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: