Skip to content

feat: impletment discovery service by zookeeper #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Road2Melon
Copy link

@Road2Melon Road2Melon commented Feb 21, 2025

What this PR does:
Implement the discovery service by Zookeeper.

Which issue(s) this PR fixes:

Fixes #580

Special notes for your reviewer:
I use the GetW function to monitor changes in Zookeeper nodes. When a node at the corresponding path changes, the corresponding operation is performed. I have written unit tests and have also verified the ZK registration and listening logic in incubator-seata-go-samples. By simply modifying the seatago.yml file and replacing the registry center with Zookeeper, TM and RM will be able to retrieve the TC's address. Below is the ZK configuration in seatago.yml.
# Registration Center registry: type: zk file: name: file zk: server-addr: 127.0.0.1:2181 session-timeout: 6000 connect-timeout: # not used username: "" # not used password: "" # not used node-path: /registry-seata/default

Does this PR introduce a user-facing change?:


@Road2Melon Road2Melon changed the title Feat discovery zookeeper feat: impletment discovery service by zookeeper Feb 21, 2025
@Code-Fight
Copy link
Contributor

Thank you very much for your PR, but I noticed that this issue was closed a long time ago. Why is it necessary to implement this feature now?

@Road2Melon
Copy link
Author

Thank you very much for your PR, but I noticed that this issue was closed a long time ago. Why is it necessary to implement this feature now?

I noticed that there are many TODO items in the discovery module, and these issues are awaiting specific implementations (including zk, nacos, etc.). These features already have concrete implementations in seata-java. I also observed that the project's contribution documentation encourages the enhancement and enrichment of features. I am quite interested in this issue, so I dedicated my efforts to researching and implementing this functionality, which may help enrich the project's features and be beneficial in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

在discovery模块中实现Zookeeper服务发现
2 participants