Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: client discovers raft nodes through the naming server #7183

Merged
merged 10 commits into from
Mar 9, 2025

Conversation

funky-eyes
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added this to the 2.4.0 milestone Feb 25, 2025
@funky-eyes funky-eyes added type: feature Category issues or prs related to feature request. module/discovery discovery module module/namingserver labels Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 4.95050% with 96 lines in your changes missing coverage. Please review.

Project coverage is 51.46%. Comparing base (117e57a) to head (b13d369).
Report is 3 commits behind head on 2.x.

Files with missing lines Patch % Lines
.../namingserver/NamingserverRegistryServiceImpl.java 0.00% 74 Missing ⚠️
...rties/registry/RegistryNamingServerProperties.java 14.28% 12 Missing ⚠️
...ata/namingserver/filter/ConsoleRemotingFilter.java 0.00% 3 Missing ⚠️
...ache/seata/namingserver/manager/NamingManager.java 50.00% 1 Missing and 2 partials ⚠️
...scovery/registry/raft/RaftRegistryServiceImpl.java 0.00% 2 Missing ⚠️
...rg/apache/seata/server/filter/RaftGroupFilter.java 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #7183      +/-   ##
============================================
- Coverage     51.56%   51.46%   -0.10%     
- Complexity     6812     6814       +2     
============================================
  Files          1169     1169              
  Lines         41482    41562      +80     
  Branches       4851     4865      +14     
============================================
  Hits          21389    21389              
- Misses        18072    18148      +76     
- Partials       2021     2025       +4     
Files with missing lines Coverage Δ
...ava/org/apache/seata/common/ConfigurationKeys.java 0.00% <ø> (ø)
...c/main/java/org/apache/seata/common/Constants.java 100.00% <ø> (ø)
...scovery/registry/raft/RaftRegistryServiceImpl.java 23.61% <0.00%> (-0.09%) ⬇️
...rg/apache/seata/server/filter/RaftGroupFilter.java 8.33% <0.00%> (-1.67%) ⬇️
...ata/namingserver/filter/ConsoleRemotingFilter.java 10.16% <0.00%> (-0.36%) ⬇️
...ache/seata/namingserver/manager/NamingManager.java 50.20% <50.00%> (-0.01%) ⬇️
...rties/registry/RegistryNamingServerProperties.java 22.58% <14.28%> (-6.84%) ⬇️
.../namingserver/NamingserverRegistryServiceImpl.java 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit d917fcf into apache:2.x Mar 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/discovery discovery module module/namingserver type: feature Category issues or prs related to feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants