feature(rm-datasource): add SQL execution monitoring in datasource proxies for Druid Connection-Pool #7588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and PoolManagerRegistry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
This PR adds SQL execution monitoring capabilities into the
rm-datasourcemodule.It instruments the following classes to capture SQL execution metrics and events:
AbstractConnectionProxyDataSourceManagerDataSourceProxyPreparedStatementProxyStatementProxyWith this change, SQL execution details can be collected and later consumed by monitoring components.
Ⅱ. Does this pull request fix one issue?
No, this is a new feature for GSoC
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
Some files (e.g.,
PoolManager, SqlMonitor, ConnectionPoolMetrics) appear as changed here because they were introduced in my previous PR (#7556), which is not yet merged.