-
Notifications
You must be signed in to change notification settings - Fork 8.9k
bugfix:Use xaActive to determine whether xaResource needs to execute the end method #7708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.x
Are you sure you want to change the base?
bugfix:Use xaActive to determine whether xaResource needs to execute the end method #7708
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #7708 +/- ##
============================================
+ Coverage 61.41% 61.53% +0.11%
+ Complexity 682 680 -2
============================================
Files 1324 1324
Lines 50047 50045 -2
Branches 5910 5910
============================================
+ Hits 30738 30796 +58
+ Misses 16531 16447 -84
- Partials 2778 2802 +24
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PRs need to be registered, and the title must clearly describe the change — not just be an issue link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses issue #7690 by fixing the XA transaction state management in the ConnectionProxyXA class. The change replaces the xaEnded flag with the existing xaActive flag to more accurately track XA transaction state and prevent redundant XA end operations.
Key Changes:
- Removed the redundant
xaEndedvolatile boolean field - Modified
xaEnd()method to checkxaActiveflag instead ofxaEnded - Updated the flag management to set
xaActive = falseafter ending the XA transaction
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
done |
|
如下测试场景通过
|
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fix #7690
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews