-
Notifications
You must be signed in to change notification settings - Fork 8.9k
optimize: support HTTP/2 push for the Watch API in Server Raft mode #7752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.x
Are you sure you want to change the base?
Conversation
# Conflicts: # server/src/test/java/org/apache/seata/server/controller/ClusterControllerTest.java
| headers.set(HttpHeaderNames.CONTENT_LENGTH, "0"); | ||
|
|
||
| ctx.write(new DefaultHttp2HeadersFrame(headers)); | ||
| ctx.write(new DefaultHttp2DataFrame(Unpooled.EMPTY_BUFFER, true)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to keep this connection open and reuse it to deliver updates whenever the leader changes, rather than requiring the client to open a new HTTP/2 watch request after every response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in 45f362e
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7752 +/- ##
============================================
- Coverage 66.17% 66.16% -0.02%
+ Complexity 994 992 -2
============================================
Files 1323 1323
Lines 50155 50184 +29
Branches 5928 5935 +7
============================================
+ Hits 33190 33203 +13
- Misses 14053 14063 +10
- Partials 2912 2918 +6
🚀 New features to boost your workflow:
|
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews