Skip to content

Conversation

@YvCeung
Copy link
Contributor

@YvCeung YvCeung commented Oct 30, 2025

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@YvCeung YvCeung changed the title optimize:Support HTTP/2 push for the Watch API in Server Raft mode optimize:support HTTP/2 push for the Watch API in Server Raft mode Oct 30, 2025
YvCeung and others added 2 commits October 30, 2025 22:50
# Conflicts:
#	server/src/test/java/org/apache/seata/server/controller/ClusterControllerTest.java
@funky-eyes funky-eyes changed the title optimize:support HTTP/2 push for the Watch API in Server Raft mode optimize: support HTTP/2 push for the Watch API in Server Raft mode Oct 31, 2025
headers.set(HttpHeaderNames.CONTENT_LENGTH, "0");

ctx.write(new DefaultHttp2HeadersFrame(headers));
ctx.write(new DefaultHttp2DataFrame(Unpooled.EMPTY_BUFFER, true));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to keep this connection open and reuse it to deliver updates whenever the leader changes, rather than requiring the client to open a new HTTP/2 watch request after every response.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 45f362e

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 60.97561% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.16%. Comparing base (61e375f) to head (45f362e).

Files with missing lines Patch % Lines
.../server/cluster/manager/ClusterWatcherManager.java 60.97% 11 Missing and 5 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #7752      +/-   ##
============================================
- Coverage     66.17%   66.16%   -0.02%     
+ Complexity      994      992       -2     
============================================
  Files          1323     1323              
  Lines         50155    50184      +29     
  Branches       5928     5935       +7     
============================================
+ Hits          33190    33203      +13     
- Misses        14053    14063      +10     
- Partials       2912     2918       +6     
Files with missing lines Coverage Δ
.../server/cluster/manager/ClusterWatcherManager.java 70.00% <60.97%> (-4.51%) ⬇️

... and 7 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants