Improve .gitignore, remove library crate Cargo.locks
#111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several of the patterns match files when they should only match directories, match anywhere in the repo when they should only match at the root, start with an unneeded `**/`, or a combination of all three. Fix all such issues as per the .gitignore documentation[1]. [1] https://git-scm.com/docs/gitignore
As per Cargo's documentation[1], only binary crates should check in Cargo.lock. Library crates should not, since dependents will do their own version resolution anyway. This mostly reverts commit 0438ca9 ("Add Cargo.lock for optee-utee and optee-teec"). [1] https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html
DemesneGH
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a couple minor fixes. Split out of #110 since that'll need some revision before it gets merged.