Skip to content

[CI] support parallel builds with JDK 11 and JDK 17 #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CalvinKirs
Copy link
Member

  • support parallel builds with JDK 11 and JDK 17
  • replace groovy-maven-plugin with gmavenplus-plugin, as groovy-maven-plugin is no longer actively maintained and does not support JDK 17.

@juripetersen
Copy link
Contributor

Thank you for your contribution!
Right now, the unit tests are failing due to Mockito having problems in some of the tests.
Did you verify your changes locally?

Another question that arises for me:
By enabling builds with JDK 17, we enable a newer version of Java. Did you confirm that this can be handled with the current version of platforms like spark and flink used?

[CI] support parallel builds with JDK 11 and JDK 17
@juripetersen
Copy link
Contributor

@CalvinKirs please address the comment above.

@zkaoudi
Copy link
Contributor

zkaoudi commented Mar 31, 2025

Hi @CalvinKirs , our project is not ready yet to support java 17 but we are close to make the right fixes. But I am still wondering if we have tests that use Java 17 features how would the build with Java 11 work? Or we shall refrain from having such tests to ensure backward compatibility?

@CalvinKirs
Copy link
Member Author

CalvinKirs commented Apr 3, 2025

Hi @CalvinKirs , our project is not ready yet to support java 17 but we are close to make the right fixes.

oops...my email may not have been officially sent... In fact, I noticed that our mailing list is considering upgrading to JDK 17, so I ran some tests through CI. Simply put, compilation works fine, but there are some compatibility issues when running tests. I haven’t looked into the details, but it might require upgrading some dependencies.

But I am still wondering if we have tests that use Java 17 features how would the build with Java 11 work? Or we shall refrain from having such tests to ensure backward compatibility?

Actually, we can build and test in parallel—kind of like this: we compile and test using both JDK 11 and 17 at the same time.

@zkaoudi
Copy link
Contributor

zkaoudi commented Apr 3, 2025

Yes we are working on using JDK 17 but not pushed changes yet.
Can we define different tests for JDK 11 and JDK 17?

Also another question that may be worth discussin in the mailing list is do we want to keep jdk 11 or we simply assume only jdk 17?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants