Skip to content

HADOOP-19877: add LocalStack/setup-localstack 0.3.2#801

Closed
ajfabbri wants to merge 2 commits intoapache:mainfrom
ajfabbri:af/hadoop-19877
Closed

HADOOP-19877: add LocalStack/setup-localstack 0.3.2#801
ajfabbri wants to merge 2 commits intoapache:mainfrom
ajfabbri:af/hadoop-19877

Conversation

@ajfabbri
Copy link
Copy Markdown

@ajfabbri ajfabbri commented May 5, 2026

Request for adding a new GitHub Action to the allow list

Overview

Localstack provides a mocked AWS environment that we want to use to run
Hadoop S3A integration tests with in CI.

Localstack has granted us some OSS licenses to use free of charge. I've
installed one API key in our repository's secrets (hadoop.git).

Name of action:

LocalStack/setup-localstack:

URL of action:
https://github.com/localstack/setup-localstack

Version to pin to (hash only):
7c8a0cb3405bc58be4c8f763f812aa000bc46303:

Permissions

We supply the action with our installed secret which associates our downloads of their test container with the donated (OSS) Localstack license:

          LOCALSTACK_AUTH_TOKEN: ${{ secrets.LOCALSTACK_CI_KEY }}

PR is here: apache/hadoop#8467

Related Actions

Checklist

You should be able to check most of these boxes for an action to be considered for review.
Please check all boxes that currently apply:

  • The action is listed in the GitHub Actions Marketplace
  • The action is not already on the list of approved actions
  • The action has a sufficient number of contributors or has contributors within the ASF community
  • The action has a clearly defined license
  • The action is actively developed or maintained
  • The action has CI/unit tests configured
  • Compiled JavaScript in dist/ matches a clean rebuild (verify with uv run utils/verify-action-build.py org/repo@hash)

Checklist for Additional Dependency (jenseng/dynamic-uses)

  • The action is listed in the GitHub Actions Marketplace
  • The action is not already on the list of approved actions
  • The action has a sufficient number of contributors or has contributors within the ASF community (only two contributors)
  • The action has a clearly defined license (ISC)
  • The action is actively developed or maintained (semi-active)
  • The action has CI/unit tests configured
  • Compiled JavaScript in dist/ matches a clean rebuild (verify with uv run utils/verify-action-build.py org/repo@hash)

@potiuk
Copy link
Copy Markdown
Member

potiuk commented May 5, 2026

Why draft?

@ajfabbri ajfabbri marked this pull request as ready for review May 5, 2026 21:25
@ajfabbri ajfabbri requested review from dfoulks1 and potiuk as code owners May 5, 2026 21:25
@ajfabbri
Copy link
Copy Markdown
Author

ajfabbri commented May 5, 2026

Why draft?

I forgot to take out of draft. Should be good to go now.

@potiuk
Copy link
Copy Markdown
Member

potiuk commented May 5, 2026

I forgot to take out of draft. Should be good to go now.

Cool.

We have this:

! Nested action jenseng/dynamic-uses@8bc24f036017 is not in our approved actions list

Can you please also add this action ?

@ajfabbri
Copy link
Copy Markdown
Author

ajfabbri commented May 5, 2026

! Nested action jenseng/dynamic-uses@8bc24f036017 is not in our approved actions list

Can you please also add this action ?

@potiuk done. Thanks for the review. I also added another checklist to the description for this additional dependency.

@potiuk
Copy link
Copy Markdown
Member

potiuk commented May 5, 2026

Can you also please rebase to latest main ? It's only today (like an hour ago) I merged fix that can verify more than 1 action submitted in a single PR.

@ajfabbri ajfabbri force-pushed the af/hadoop-19877 branch from 8eedc49 to db0d2c0 Compare May 6, 2026 00:19
@ajfabbri
Copy link
Copy Markdown
Author

ajfabbri commented May 6, 2026

@potiuk much appreciated! I rebased on main. We should probably wait to merge this--I just discovered I may want to skip this action and set it up manually. I will let you know when I'm done iterating on my CI PR that uses this. (we could also merge now and I'll submit a revert PR if we don't end up using it, of course).

@ajfabbri ajfabbri closed this May 6, 2026
@ajfabbri
Copy link
Copy Markdown
Author

ajfabbri commented May 6, 2026

I went ahead and closed this PR. Apologies for the noise, but I didn't realize that I was going to be using a different mechanism to set this up. So I don't need these actions. Thanks again.

@ajfabbri ajfabbri deleted the af/hadoop-19877 branch May 6, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants