Skip to content

Conversation

@Caideyipi
Copy link
Collaborator

@Caideyipi Caideyipi commented Nov 28, 2025

Description

As the title said.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@Caideyipi Caideyipi changed the title [To dev/1.3] Fixed the schema cache calculation 2 [To dev/1.3] Fixed the schema cache calculation 2 Nov 28, 2025
@Caideyipi Caideyipi changed the title [To dev/1.3] Fixed the schema cache calculation 2 [To dev/1.3] Fixed the schema cache calculation 2 (#16834) Nov 28, 2025
@Caideyipi Caideyipi changed the title [To dev/1.3] Fixed the schema cache calculation 2 (#16834) [To dev/1.3] Fixed the schema cache calculation 2 & The potential NPE caused by concurrent invalidate and update (#16834) & The schema cache is not cleared for "clear schema cache" Nov 28, 2025
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 54.76190% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.10%. Comparing base (bab1937) to head (b1cd653).

Files with missing lines Patch % Lines
...ine/plan/analyze/cache/schema/DeviceLastCache.java 44.44% 10 Missing ⚠️
...che/schema/dualkeycache/impl/DualKeyCacheImpl.java 66.66% 4 Missing ⚠️
...ol/thrift/impl/DataNodeInternalRPCServiceImpl.java 0.00% 3 Missing ⚠️
...e/iotdb/db/queryengine/plan/parser/ASTVisitor.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev/1.3   #16833      +/-   ##
=============================================
+ Coverage      41.08%   41.10%   +0.01%     
  Complexity       198      198              
=============================================
  Files           3589     3589              
  Lines         235980   235975       -5     
  Branches       28507    28504       -3     
=============================================
+ Hits           96946    96986      +40     
+ Misses        139034   138989      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant