OAK-11427 : removed usage of Guava Iterables.isEmpty#2023
Merged
rishabhdaim merged 3 commits intotrunkfrom Jan 24, 2025
Merged
Conversation
Commit-Check ✔️ |
reschke
reviewed
Jan 23, 2025
| if (iterable instanceof Collection) { | ||
| return ((Collection<?>) iterable).isEmpty(); | ||
| } | ||
| return StreamUtils.toStream(iterable).findAny().isEmpty(); |
Contributor
There was a problem hiding this comment.
Is that better than simply saying:
iterable.getIterator().hasNext()
?
Contributor
Author
There was a problem hiding this comment.
@reschke I think we should go with https://commons.apache.org/proper/commons-collections/apidocs/org/apache/commons/collections4/IterableUtils.html#isEmpty(java.lang.Iterable).
Will update the PR.
|
reschke
approved these changes
Jan 24, 2025
andreeastroe96
pushed a commit
to andreeastroe96/jackrabbit-oak
that referenced
this pull request
Feb 25, 2025
* OAK-11427 : removed usage of Guava Iterables.isEmpty * OAK-11427 : fixed import issue * OAK-11427 : used commons-collections4 IterableUtils.isEmpty --------- Co-authored-by: Rishabh Kumar <diam@adobe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.