OAK-11433 : added OSGi config for setting max revision age for full gc#2032
Merged
rishabhdaim merged 2 commits intotrunkfrom Jan 31, 2025
Merged
OAK-11433 : added OSGi config for setting max revision age for full gc#2032rishabhdaim merged 2 commits intotrunkfrom
rishabhdaim merged 2 commits intotrunkfrom
Conversation
Commit-Check ✔️ |
mbaedke
requested changes
Jan 29, 2025
| Map<String, Object> props = jobPropertiesFor(RevisionGCJob.class); | ||
| props.put("scheduler.expression", expr); | ||
| long versionGcMaxAgeInSecs = config.versionGcMaxAgeInSecs(); | ||
| long fullGcMaxAgeInSecs = config.fullGcMaxAgeInSecs(); |
reschke
reviewed
Jan 29, 2025
| private final boolean isFullGCDryRun; | ||
| private final boolean embeddedVerification; | ||
| private final double fullGCDelayFactor; | ||
| private long fullGcMaxAgeInMillis; |
Contributor
There was a problem hiding this comment.
can this be "final" for consistency?
Contributor
Author
There was a problem hiding this comment.
We are setting this in setFullGcMaxAge(), so it can't be made final.
| gc.setFullGcMaxAge(maxRevisionAge, unit); // set full gc max age | ||
| final VersionGarbageCollector.VersionGCStats stats = gc.gc(maxRevisionAge, unit); | ||
| if (stats.skippedFullGCDocsCount != 0) { | ||
| (new Exception("here: " + stats.skippedFullGCDocsCount)).printStackTrace(System.out); |
Contributor
Author
There was a problem hiding this comment.
this has been added to help in printing the error to console in case of failures while running test cases.
mbaedke
approved these changes
Jan 29, 2025
Joscorbe
approved these changes
Jan 30, 2025
andreeastroe96
pushed a commit
to andreeastroe96/jackrabbit-oak
that referenced
this pull request
Feb 25, 2025
apache#2032) * OAK-11433 : added OSGi config for setting max revision age for full gc * OAK-11433 : removed un-used var --------- Co-authored-by: Rishabh Kumar <diam@adobe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.