OAK-11452 : exported full gc OSGi configs as metrics#2054
Conversation
Commit-Check ✔️ |
rishabhdaim
force-pushed
the
OAK-11452
branch
from
e8f5824 to
33e12df
Compare
|
rishabhdaim
requested review from
Joscorbe,
joerghoh,
mbaedke and
thomasmueller
|
This implementation is based on the Guage metrics implementation in sling metrics https://github.com/apache/sling-org-apache-sling-commons-metrics/blob/master/src/main/java/org/apache/sling/commons/metrics/internal/MetricsServiceImpl.java#L128 |
|
I don't know enough about the metrics stuff to comments. But please have a look at the code coverage warnings. |
This low coverage is due to toString() in FullGCStatsCollectorImpl class. Added a test case to cover that as well in 12591b6. |
|
|
||
| /** | ||
| * Creates a new {@link GaugeStats} and registers it under the given name. | ||
| * If a gauge with the same exists already then the same instance is returned. |
There was a problem hiding this comment.
s/the same exists/the same name exists
|
Same as with Julian: I don't know that well enough to review. LGTM :) |
…gc OSGi configs as metrics as Guage values
|
5 participants
No description provided.