OAK-11570 oak-run fullGC fullGcMaxAge default value is wrongly calculated#2157
OAK-11570 oak-run fullGC fullGcMaxAge default value is wrongly calculated#2157Joscorbe merged 2 commits intoapache:trunkfrom
Conversation
| assertTrue(output.contains("FullGcBatchSize is : 1000")); | ||
| assertTrue(output.contains("FullGcProgressSize is : 10000")); | ||
| assertTrue(output.contains("FullGcMaxAgeInSecs is : 86400")); | ||
| assertTrue(output.contains("FullGcMaxAgeInSecs is : 86400\n")); |
There was a problem hiding this comment.
I assume the \n is to ensure the value is exactly 86400 and not something else containing that string, but I wonder if we should then apply the same to the rest of asserts to maintain consistency.
There was a problem hiding this comment.
yes, the wrong value was 86400000 and was still passing the test
i've updated the same for all numeric values checks
There was a problem hiding this comment.
This change breaks tests on Windows systems.
There was a problem hiding this comment.
Nitpicking: why is there a space before the colons?
There was a problem hiding this comment.
This change breaks tests on Windows systems.
Do we need to change this before CF?
Nitpicking: why is there a space before the colons?
I think this has been done to it consistent with other verifications done.
There was a problem hiding this comment.
-
It should be trivial; I'm on it.
-
Ack.
There was a problem hiding this comment.
4 participants
fixed conversion where default value is converted to millis not seconds