OAK-11594 - Converting existing indexes from a type to another leaves the async lane the same #2173
+67
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibulcuteanu
force-pushed
the
OAK-11594
branch
3 times, most recently
from
c7302c9 to
caad7b6
Compare
alagodasii
reviewed
Mar 14, 2025
| String idxBuilderType = idxBuilder.getString(TYPE_PROPERTY_NAME); | ||
|
|
||
| // check if provided index definitions is of different type than existing one | ||
| if (idxBuilderType != null && |
There was a problem hiding this comment.
Can be replaced with StringUtils.equals()
alagodasii
approved these changes
Mar 14, 2025
fabriziofortino
requested changes
Mar 14, 2025
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/importer/IndexImporter.java
Show resolved
Hide resolved
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/importer/IndexImporter.java
Outdated
Show resolved
Hide resolved
chibulcuteanu
force-pushed
the
OAK-11594
branch
from
caad7b6 to
b537d53
Compare
fabriziofortino
approved these changes
Mar 17, 2025
tihom88
requested changes
Mar 17, 2025
oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/importer/IndexImporterTest.java
Show resolved
Hide resolved
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/importer/IndexImporter.java
Show resolved
Hide resolved
oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/importer/IndexImporterTest.java
Show resolved
Hide resolved
|
@tihom88 can you please re-review based on latest comments? |
tihom88
approved these changes
Mar 20, 2025
… the async lane the same
chibulcuteanu
force-pushed
the
OAK-11594
branch
from
0f77dbc to
f63c95a
Compare
|
I've update the branch to remove unused imports. Can someone please approve the workflows? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OAK-11594 - Converting existing indexes from a type to another leaves the async lane the same