Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAK-11568 Elastic: improved compatibility for aggregation definitions #2193

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

thomasmueller
Copy link
Member

@thomasmueller thomasmueller commented Mar 19, 2025

  • Analyzer configuration is now lenient, quite similar to the Lucene index behavior. This will allow converting Lucene indexes to Elasticsearch. Warnings are logged where needed.
  • This PR also removes unused code, and reduces compiler warnings.
  • The tests in ElasticIndexHelperTest are about problems trying to load files that are not configured (IllegalStateException etc.)
  • The tests in FullTextAnalyzerCommonTest are about compatibility problems
  • With the NGram Tokenizer (not filter), behaviour is different between Elastic and Lucene for one case: if the query contains multiple words, the result is found with Lucene, but not with Elastic.

Copy link

Commit-Check ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant