OAK-11619 - Fix flaky ConcurrentMultiplexingIndexWriterTest #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are stopped before the test terminates and the directories with the Lucene data are removed.
fabriziofortino
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LuceneIndexWriterFactorywas not being closed by the test. This object contains a thread pool with the Lucene index writers which write data to disk on the background. After the test ends, JUnit deletes the test directory where all the Lucene data was written. If the Lucene writer threads try to access the Lucene files after the files are deleted, they will fail. This is likely what was causing the failure.This PR closes the the
LuceneIndexWriterFactoryat the end of the test.