Skip to content

OAK-11737: Properly set embeddedVerification value on FullGC revisions command#2307

Merged
Joscorbe merged 2 commits intotrunkfrom
OAK-11737
Jun 23, 2025
Merged

OAK-11737: Properly set embeddedVerification value on FullGC revisions command#2307
Joscorbe merged 2 commits intotrunkfrom
OAK-11737

Conversation

@Joscorbe
Copy link
Member

@Joscorbe Joscorbe commented May 23, 2025

So there were 2 issues:

  1. EmbeddedVerification is enabled by default, so it was impossible to disable it because it only set the value to the builder if it is true, in case of false it was never executed, so it remained enabled.
  2. collectDocument method was not setting EmbeddedVerification value at all.

@Joscorbe Joscorbe requested a review from rishabhdaim May 23, 2025 13:45
@github-actions
Copy link

Commit-Check ✔️

@sonarqubecloud
Copy link

@rishabhdaim
Copy link
Contributor

rishabhdaim commented May 23, 2025

Could you please add a test case for this?

@Joscorbe
Copy link
Member Author

I have added some improvements to the FullGC command output, and now it outputs actually applied settings to the VersionGarbageCollector object, instead of just the options passed to the command.

In fact, this helped me to detect another issue: included/excluded paths were not set, so any value sent to the RevisionsCommand was ignored. This is also fixed now in the same PR.

@Joscorbe Joscorbe merged commit 432021b into trunk Jun 23, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants