OAK-11747 : removed usage of Guava's ComparisonChain with JDK comparator#2319
Merged
rishabhdaim merged 1 commit intotrunkfrom Jun 5, 2025
Merged
OAK-11747 : removed usage of Guava's ComparisonChain with JDK comparator#2319rishabhdaim merged 1 commit intotrunkfrom
rishabhdaim merged 1 commit intotrunkfrom
Conversation
Commit-Check ✔️ |
rishabhdaim
commented
May 30, 2025
| } | ||
|
|
||
| private MimeTypeStats createStat(String mimeType) { | ||
| MimeTypeStats createStat(String mimeType) { |
Contributor
Author
There was a problem hiding this comment.
Scope increased to add test cases for MimeTypeStats comparison.
rishabhdaim
commented
May 30, 2025
| } | ||
|
|
||
| private static class MimeTypeStats implements Comparable<MimeTypeStats> { | ||
| static class MimeTypeStats implements Comparable<MimeTypeStats> { |
Contributor
Author
There was a problem hiding this comment.
Scope increased to add test cases for MimeTypeStats comparison.
|
reschke
reviewed
Jun 2, 2025
| .result(); | ||
| public int compareTo(@NotNull Tuple2 o) { | ||
| return Comparator.comparing((Tuple2 t) -> t.value) | ||
| .thenComparing( t -> ((Tuple2) t).value2, Comparator.reverseOrder()) |
Contributor
There was a problem hiding this comment.
Suggested change
| .thenComparing( t -> ((Tuple2) t).value2, Comparator.reverseOrder()) | |
| .thenComparing(t -> ((Tuple2) t).value2, Comparator.reverseOrder()) |
reschke
approved these changes
Jun 2, 2025
Contributor
reschke
left a comment
reschke
left a comment
There was a problem hiding this comment.
Wow, makes the code much more readable. But see the 1 whitespace nit.
reschke
pushed a commit
that referenced
this pull request
Jun 12, 2025
…tor (#2319) Co-authored-by: Rishabh Kumar <diam@adobe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.