OAK-11775: improve is null queries for elasticsearch indexes#2346
Merged
fabriziofortino merged 9 commits intoapache:trunkfrom Jun 24, 2025
Merged
OAK-11775: improve is null queries for elasticsearch indexes#2346fabriziofortino merged 9 commits intoapache:trunkfrom
is null queries for elasticsearch indexes#2346fabriziofortino merged 9 commits intoapache:trunkfrom
Conversation
fabriziofortino
changed the title
is null queriesis null queries for elasticsearch indexes
...c/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java
Outdated
Show resolved
Hide resolved
…gins/index/elastic/query/ElasticRequestHandler.java fix typo Co-authored-by: Thomas Mueller <thomas.tom.mueller@gmail.com>
nfsantos
approved these changes
Jun 23, 2025
...tic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticDocument.java
Show resolved
Hide resolved
...c/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java
Outdated
Show resolved
Hide resolved
tihom88
reviewed
Jun 24, 2025
| // check if the default mapping is >= 1.5.0 | ||
| if (ElasticIndexDefinition.MAPPING_VERSION != null && | ||
| ElasticIndexDefinition.MAPPING_VERSION.compareTo(new ElasticSemVer(1, 5, 0)) >= 0) { | ||
| LOG.error("Backward compatibility for null check is not supported anymore. Query results may be incorrect. " + |
Contributor
There was a problem hiding this comment.
I think we should decrease logging these on each query execution., may be once every 100/1000 queries.
Contributor
Author
There was a problem hiding this comment.
I thought about that but I decided to not add this complexity for the following reasons:
- this message is not printed for every query, only the once using
is null(which shouldn't be that common) - we have a way to get rid of these logs: reindexing is required and it will improve both response time and resource usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.