[ENHANCEMENT] OIDC SASL code refactoring #2888
Open
+416
−270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mutualize code for choosing how code shall be validated between IMAP and SMTP - Turn OidcJwtTokenVerifier as a class - Have SASL configuration as a member in order to limit count of arguments
Contributor
|
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (check-style) on project protocols-imap: You have 1 Checkstyle violation. -> [Help 1] will check... |
Arsnael
approved these changes
Dec 22, 2025
Contributor
Author
|
Please help push fixes on this... (Currently in vacation for 2 weeks) |
Docker v29 introduces a breaking change in the client API requirement: https://docs.docker.com/engine/release-notes/29/#breaking-changes This introduces an issue with testcontainers cf testcontainers/testcontainers-java#11212 CI builds failed because of this: `client version 1.32 is too old. Minimum supported API version is 1.44, please upgrade your client to a newer version`. In the time waiting for a new release of testcontainers, we can apply the recommended workaround to enforce client version to required v1.44.
cf opencontainers/runc#4971 runc update recently has resulted in the default permissions on docker tmpfs being 0755 rather than the expected 1777, which makes OpenSearch tests failed to acquire the lock on file system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.