JSR223 uniform and verbose logging - #6511
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
JSR223 compile errors show in various formats in log and more impacting is the fact that one doesn't always has access to sampler name or it's not clear where it starts and where it ends; also, stack traces are sometimes duplicated, making reading a lot harder.
I've simply unified the log statements for JSR223 elements while sampler name is included between simple quotes and removed double stack trace printing.
Motivation and Context
Hard to debug or to analyze root cause of a JSR223 related failure.
How Has This Been Tested?
Run various JSR223 elements with incorrect scripts to force compilation failure.
Screenshots (if appropriate):
Types of changes
Checklist: