Skip to content

Commit 42ea206

Browse files
committed
MINOR: remove stale zk comment
Signed-off-by: PoAn Yang <payang@apache.org>
1 parent 21340a4 commit 42ea206

2 files changed

Lines changed: 0 additions & 2 deletions

File tree

storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -562,7 +562,6 @@ public void stopPartitions(Set<StopPartition> stopPartitions,
562562

563563
// We want to remote topicId map and stopPartition on RLMM for deleteLocalLog or stopRLMM partitions because
564564
// in both case, they all mean the topic will not be held in this broker anymore.
565-
// NOTE: In ZK mode, this#stopPartitions method is called when Replica state changes to Offline and ReplicaDeletionStarted
566565
Set<TopicIdPartition> pendingActionsPartitions = stopPartitions.stream()
567566
.filter(sp -> (sp.stopRemoteLogMetadataManager || sp.deleteLocalLog) && topicIdByPartitionMap.containsKey(sp.topicPartition))
568567
.map(sp -> new TopicIdPartition(topicIdByPartitionMap.get(sp.topicPartition), sp.topicPartition))

storage/src/test/java/org/apache/kafka/tiered/storage/integration/DeleteSegmentsDueToLogStartOffsetBreachTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ private void executeDeleteSegmentsDueToLogStartOffsetBreachTest(ClusterInstance
9696
.expectDeletionInRemoteStorage(broker0, topicA, p0, DELETE_SEGMENT, 1)
9797
.deleteRecords(topicA, p0, beforeOffset)
9898
// expect that the leader epoch checkpoint is updated
99-
// Comment out this line if it's FLAKY since the leader-epoch is not deterministic in ZK mode.
10099
.expectLeaderEpochCheckpoint(broker0, topicA, p0, beginEpoch, startOffset)
101100
// consume from the offset-3 of the topic to read data from local and remote storage
102101
.expectFetchFromTieredStorage(broker0, topicA, p0, 1)

0 commit comments

Comments
 (0)