-
Notifications
You must be signed in to change notification settings - Fork 14.3k
KAFKA-17456: Make sure FindCoordinatorResponse get created before consumer #17404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @frankvicky for the PR!
If this deflakes the tests, that would be a big win as the KafkaConsumerTest
is one of the flakiest tests we have. We need to run the corresponding tests many times (I don't have an exact number) for both consumers to ensure that we've fixed the flakiness and haven't introduced any regressions.
Thanks!
@frankvicky—where are we on merging this? It appears the build and all tests pass. |
@chia7712 Could you please take a look ? |
@@ -2412,15 +2410,15 @@ public void testReturnRecordsDuringRebalance(GroupProtocol groupProtocol) throws | |||
ConsumerMetadata metadata = createMetadata(subscription); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looped testReturnRecordsDuringRebalance
and see the following error:
Gradle Test Run :clients:test > Gradle Test Executor 253 > KafkaConsumerTest > testReturnRecordsDuringRebalance(GroupProtocol) > "testReturnRecordsDuringRebalance(GroupProtocol).groupProtocol=CLASSIC" FAILED
org.opentest4j.AssertionFailedError: expected: <11> but was: <0>
at app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
at app//org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
at app//org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:150)
at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:145)
at app//org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:531)
at app//org.apache.kafka.clients.consumer.KafkaConsumerTest.testReturnRecordsDuringRebalance(KafkaConsumerTest.java:2440)
@frankvicky could you please check it?
This PR is being marked as stale since it has not had any activity in 90 days. If you If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact). If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. |
JIRA: KAFKA-17456
Committer Checklist (excluded from commit message)