Skip to content

KAFKA-17688 Move TransactionsTest to storage module #17732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Draft

KAFKA-17688 Move TransactionsTest to storage module #17732

wants to merge 4 commits into from

Conversation

m1a2st
Copy link
Collaborator

@m1a2st m1a2st commented Nov 10, 2024

Jira: https://issues.apache.org/jira/browse/KAFKA-17688

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added core Kafka Broker storage Pull requests that target the storage module build Gradle build or GitHub Actions labels Nov 10, 2024
dajac
dajac reviewed Nov 10, 2024
View reviewed changes
storage/src/test/java/org/apache/kafka/tiered/storage/integration/TransactionsTest.java
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.kafka.tiered.storage.integration;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure about the location? This suite of tests seems to be an integration tests which is not specific to storage nor to tiered storage.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2025

This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

@github-actions github-actions bot added the stale Stale PRs label Feb 9, 2025
@m1a2st
Merge branch 'trunk' into KAFKA-17688
4c1ac58 
# Conflicts:
#	build.gradle
@github-actions github-actions bot removed the stale Stale PRs label Feb 10, 2025
@github-actions GitHub Actions
Copy link

This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

@github-actions github-actions bot added the stale Stale PRs label May 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dajac dajac dajac left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
build Gradle build or GitHub Actions core Kafka Broker stale Stale PRs storage Pull requests that target the storage module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m1a2st @dajac