KAFKA-18201: testGroupMetadataMessageFormatter fails for new consumer protocol #18198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankYang0529
force-pushed
the
KAFKA-18201
branch
from
1d094fe to
7a431b1
Compare
FrankYang0529
force-pushed
the
KAFKA-18201
branch
from
7a431b1 to
9f406e3
Compare
github-actions
bot
added
tests
FrankYang0529
force-pushed
the
KAFKA-18201
branch
2 times, most recently
from
8756298 to
61857c9
Compare
|
Hi @lianetm, could you help me review this when you have time? Thank you. |
FrankYang0529
force-pushed
the
KAFKA-18201
branch
3 times, most recently
from
02fa3a5 to
628f1a3
Compare
… protocol Signed-off-by: PoAn Yang <[email protected]>
FrankYang0529
force-pushed
the
KAFKA-18201
branch
from
628f1a3 to
95bf760
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced new coordinator record for async kafka consumer like ConsumerGroupMetadataKey, ConsumerGroupPartitionMetadataKey, etc. The GroupMetadataMessageFormatter didn't support these message type. We should add another test case for consumer group protocol.
Committer Checklist (excluded from commit message)