KAFKA-10730: KafkaApis#handleProduceRequest should use auto-generated protocol

[FrankYang0529]

This is follow-up of KAFKA-9628 the construction of ProduceResponse is able to accept auto-generated protocol data so KafkaApis#handleProduceRequest should apply auto-generated protocol to avoid extra conversion.

Committer Checklist (excluded from commit message)

• Verify design and implementation
• Verify test coverage and CI build status
• Verify documentation (including upgrade notes)

[ijuma]

This added twice as much code as it removed - the benefit doesn't seem to justify the cost. If we want to do this, we should avoid all the extra verbosity.

[FrankYang0529]

This added twice as much code as it removed

Old code only uses single line to represent a response, but new structure use builder pattern, so it takes more lines.

Old one:

new ProduceResponse.PartitionResponse(error, offset, RecordBatch.NO_TIMESTAMP, logStartOffset);

New one:

new ProduceResponseData.PartitionProduceResponse()
    .setIndex(tp.partition())
    .setErrorCode(error.code())
    .setBaseOffset(offset)
    .setLogStartOffset(logStartOffset)
    .setLogAppendTimeMs(RecordBatch.NO_TIMESTAMP)

[ijuma]

Right, so why do we want to do this? What's the benefit?

[FrankYang0529]

Hi @ijuma, thanks for the review. The good part is that we eliminate data conversion time. We don't need to convert data from PartitionResponse to ProduceResponseData.PartitionProduceResponse.

Before (trunk):

Result "org.apache.kafka.jmh.producer.ProducerResponseBenchmark.constructorProduceResponse":
  209.285 ±(99.9%) 1.822 ns/op [Average]
  (min, avg, max) = (204.419, 209.285, 211.999), stdev = 1.705
  CI (99.9%): [207.463, 211.108] (assumes normal distribution)

After (this branch):

Result "org.apache.kafka.jmh.producer.ProducerResponseBenchmark.constructorProduceResponse":
  139.632 ±(99.9%) 36.446 ns/op [Average]
  (min, avg, max) = (67.455, 139.632, 173.913), stdev = 34.091
  CI (99.9%): [103.187, 176.078] (assumes normal distribution)

[FrankYang0529]

Hi @chia7712 @ijuma, may you help me review this when you have time? Thanks.