-
Notifications
You must be signed in to change notification settings - Fork 14.4k
Feature/arch analysis #18356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Feature/arch analysis #18356
Conversation
A label of 'needs-attention' was automatically added to this PR in order to raise the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Jacck, thanks for the patch!
Could you explain this change in a bit more detail? What exactly are these scripts doing and what is the benefit to Kafka?
My intent is to analyse Kafka architecture, especially to measure coupling, after each commit |
Gotcha, ok. This kind of analysis is interesting, albeit a bit academic. It's doesn't exactly give us actionable information. I think the contributors are already quite aware of the class and module level coupling that exists in Kafka :) So I'm a bit hesitant to add this to our build. I would suggest that you run this on a fork of apache/kafka or pull in the Kafka sources as a submodule on your own project. That would let us see the results and determine if it's worth including. |
This PR is being marked as stale since it has not had any activity in 90 days. If you If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact). If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. |
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)