Skip to content

Feature/arch analysis #18356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: trunk
Choose a base branch
from
Open

Feature/arch analysis #18356

wants to merge 9 commits into from

Conversation

Jacck
Copy link

@Jacck Jacck commented Dec 31, 2024

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added triage PRs from the community build Gradle build or GitHub Actions labels Dec 31, 2024
Copy link

github-actions bot commented Jan 7, 2025

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

Copy link
Member

@mumrah mumrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Jacck, thanks for the patch!

Could you explain this change in a bit more detail? What exactly are these scripts doing and what is the benefit to Kafka?

@github-actions github-actions bot removed needs-attention triage PRs from the community labels Feb 22, 2025
@Jacck
Copy link
Author

Jacck commented Feb 22, 2025

My intent is to analyse Kafka architecture, especially to measure coupling, after each commit

@mumrah
Copy link
Member

mumrah commented Feb 24, 2025

Gotcha, ok. This kind of analysis is interesting, albeit a bit academic. It's doesn't exactly give us actionable information. I think the contributors are already quite aware of the class and module level coupling that exists in Kafka :)

So I'm a bit hesitant to add this to our build. I would suggest that you run this on a fork of apache/kafka or pull in the Kafka sources as a submodule on your own project. That would let us see the results and determine if it's worth including.

Copy link

This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

@github-actions github-actions bot added the stale Stale PRs label May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Gradle build or GitHub Actions stale Stale PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants