[WIP] KAFKA-18562: standardize election/fetch timeout between Unattached and Followers #18921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankvicky
force-pushed
the
KAFKA-18562
branch
2 times, most recently
from
beff261 to
0361567
Compare
frankvicky
commented
Feb 17, 2025
There was a problem hiding this comment.
Hi @ahuang98
I'm not certain if it is the right way for this patch.
Please take a look if you have a free moment.
Many thanks 🙇🏼
| @@ -3279,7 +3279,7 @@ private long pollUnattachedAsVoter(UnattachedState state, long currentTimeMs) { | |||
| // If shutting down, then remain in this state until either the | |||
| // shutdown completes or an epoch bump forces another state transition | |||
| return shutdown.remainingTimeMs(); | |||
| } else if (state.hasElectionTimeoutExpired(currentTimeMs)) { | |||
| } else if (state.hasFetchTimeoutExpired(currentTimeMs)) { | |||
There was a problem hiding this comment.
If I understand correctly, we should use fetch timeout instead of election timeout when aligning with the follower's transition to the prospective state.
frankvicky
force-pushed
the
KAFKA-18562
branch
2 times, most recently
from
5f6381a to
023c26d
Compare
…d Followers JIRA: KAFKA-18562
frankvicky
force-pushed
the
KAFKA-18562
branch
from
023c26d to
14cc50e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: KAFKA-18562
Committer Checklist (excluded from commit message)