Skip to content

KAFKA-18424: Consider splitting PlaintextAdminIntegrationTest#testConsumerGroups #19093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 36 commits into
base: trunk
Choose a base branch
from
Open

KAFKA-18424: Consider splitting PlaintextAdminIntegrationTest#testConsumerGroups #19093

wants to merge 36 commits into from

Conversation

frankvicky
Copy link
Contributor

@frankvicky frankvicky commented Mar 4, 2025 •
edited
Loading

JIRA: KAFKA-18424
PlaintextAdminIntegrationTest#testConsumerGroups test too many things. We should split it into smaller units.

@frankvicky
KAFKA-18424: Consider splitting PlaintextAdminIntegrationTest#testCon…
6c71869 
…sumerGroups

JIRA: KAFKA-18424
PlaintextAdminIntegrationTest#testConsumerGroups tests too many things.
We should split it into smaller units.
@github-actions github-actions bot added triage PRs from the community core Kafka Broker tests Test fixes (including flaky tests) labels Mar 4, 2025
@github-actions GitHub Actions
Copy link

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

@github-actions GitHub Actions
Copy link

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

@github-actions GitHub Actions
Copy link

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

@github-actions GitHub Actions
Copy link

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

@github-actions GitHub Actions
Copy link

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

@github-actions github-actions bot removed the triage PRs from the community label Mar 28, 2025
frankvicky
frankvicky commented Apr 2, 2025
View reviewed changes
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala
Comment on lines +1978 to +1983
val producer = createProducer()
try {
producer.send(new ProducerRecord(testTopicName, 0, null, null)).get()
} finally {
Utils.closeQuietly(producer, "producer")
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add it to deflaky for assertion of groupEpoch.
Not sure why the empty topic will lead to groupEpoch changing.
I'm still investigating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chia7712 chia7712 chia7712 approved these changes

Assignees
No one assigned
Labels
ci-approved core Kafka Broker tests Test fixes (including flaky tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frankvicky @chia7712 @brandboat