KAFKA-19070: add taskId to consumer override clientId #19382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this may require a KIP as this would potentially break some client code if people try to do matching on the overridden client id which would no longer match as the string would be different. I have also noticed this being done with other configs, for example 'connector-producer-', so if this is a sensible approach, it may be worth applying this change to a wider set of configs. |
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: KAFKA-19070
The default clientId for the connector consumer is 'connector-consumer-' plus the task id value. When a user overrides this the task id value is not used and it's not possible to differentiate between the different tasks using the overridden clientId.
The idea is to append the taskId that is used in the default clientId to the user defined value.