MINOR: Port changes from KAFKA-18569 for ShareConsumers #19402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
AndrewJSchofield
added
KIP-932
AndrewJSchofield
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ShareConsumersmay wait on an unneededFindCoordinatorduringclose()(i.e after the acknowledgements are sent).This change KAFKA-18569: New consumer close may wait on unneeded FindCoordinator #18590 added the
StopFindCoordinatorOnCloseevent and was used by the regularconsumers. We are using the same event in
ShareConsumersas well toprevent sending this event when coordinator is no longer needed.