KAFKA-19117: Client Throttling Log messages should be of log level - WARN (Java client) #19456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We experienced an outage in our application due to a built up Kafka lag, which we eventually discovered to be the problem with Kafka Clients being throttled.
Even when using the confluent cluster, the dashboard does point to exceeding the quota of the principal.
It will be nice, if the log message on the client side is a WARNING. This helps those who don't have visibility to cluster, and just look at the problem from the client side, setup alerts etc. (instead of enabling TRACE to figure out where the problem is)
NetworkClient#maybeThrottle in the class NetworkClient:
Changed from:
log.trace("Connection to node {} is throttled for {} ms until timestamp {}", nodeId, throttleTimeMs, now + throttleTimeMs);
to
log.warn("Connection to node {} is throttled for {} ms until timestamp {}", nodeId, throttleTimeMs, now + throttleTimeMs);