Skip to content

KAFKA-18629: Account for existing deleting topics in share group delete. #19463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 15, 2025
Merged

KAFKA-18629: Account for existing deleting topics in share group delete. #19463

merged 7 commits into from
Apr 15, 2025

Conversation

smjn
Copy link
Collaborator

@smjn smjn commented Apr 14, 2025 •
edited by github-actions bot
Loading

  • When deleting share groups, only initialized and initializing
    information in the metadata record is considered. However, it could
    happen that the deleting topics also contains info due to other RPCs
    (share group offsets delete).
  • We need to account for existing information while writing the metadata
    record in the delete flow.
  • This PR aims to add the impl for the same. New tests have been added
    to check the functionality.

@smjn smjn requested a review from AndrewJSchofield April 14, 2025 10:44
@github-actions github-actions bot added triage PRs from the community small Small PRs labels Apr 14, 2025
@smjn smjn added KIP-932 Queues for Kafka small Small PRs ci-approved and removed small Small PRs triage PRs from the community labels Apr 14, 2025
@github-actions github-actions bot removed the small Small PRs label Apr 15, 2025
AndrewJSchofield
AndrewJSchofield approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@AndrewJSchofield AndrewJSchofield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

@AndrewJSchofield AndrewJSchofield merged commit cdbb8fa into apache:trunk Apr 15, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewJSchofield AndrewJSchofield AndrewJSchofield approved these changes

Assignees
No one assigned
Labels
ci-approved KIP-932 Queues for Kafka
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smjn @AndrewJSchofield