KAFKA-19137: Use StandardCharsets.UTF_8 instead of StandardCharsets.UTF_8.name()
#19464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
|
@xijiu could you please merge trunk to run CI again? |
Yeah, I have merged it, PTAL |
FrankYang0529
approved these changes
Apr 15, 2025
| } | ||
| String encodedSource = encodePath(sourceAndTarget.source()); | ||
| String encodedTarget = encodePath(sourceAndTarget.target()); | ||
| List<String> restNamespace = Arrays.asList(encodedSource, encodedTarget); |
m1a2st
reviewed
Apr 15, 2025
| final ProcessorSupplier<String, Integer, Void, Void> supplier = new PrintedInternal<>(sysOutPrinter).build("processor"); | ||
| final Processor<String, Integer, Void, Void> processor = supplier.get(); | ||
|
|
||
| processor.process(new Record<>("good", 2, 0L)); | ||
| processor.close(); | ||
| assertThat(sysOut.toString(StandardCharsets.UTF_8.name()), equalTo("[processor]: good, 2\n")); | ||
| assertThat(sysOut.toString(StandardCharsets.UTF_8), equalTo("[processor]: good, 2\n")); |
There was a problem hiding this comment.
We should use assertEquals instead of assertThat
| final Processor<String, Integer, Void, Void> processor = new PrintedInternal<>(sysOutPrinter.withLabel("label")) | ||
| .build("processor") | ||
| .get(); | ||
|
|
||
| processor.process(new Record<>("hello", 3, 0L)); | ||
| processor.close(); | ||
| assertThat(sysOut.toString(StandardCharsets.UTF_8.name()), equalTo("[label]: hello, 3\n")); | ||
| assertThat(sysOut.toString(StandardCharsets.UTF_8), equalTo("[label]: hello, 3\n")); |
There was a problem hiding this comment.
ditto: We should use assertEquals instead of assertThat
| final Processor<String, Integer, Void, Void> processor = new PrintedInternal<>( | ||
| sysOutPrinter.withKeyValueMapper((key, value) -> String.format("%s -> %d", key, value)) | ||
| ).build("processor").get(); | ||
| processor.process(new Record<>("hello", 1, 0L)); | ||
| processor.close(); | ||
| assertThat(sysOut.toString(StandardCharsets.UTF_8.name()), equalTo("[processor]: hello -> 1\n")); | ||
| assertThat(sysOut.toString(StandardCharsets.UTF_8), equalTo("[processor]: hello -> 1\n")); |
There was a problem hiding this comment.
ditto: We should use assertEquals instead of assertThat
|
@FrankYang0529 @m1a2st Thanks very much for the code review, and I have fixed it, PTAL |
chia7712
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
StandardCharsets.UTF_8.name()withStandardCharsets.UTF_8toavoid UnsupportedEncodingException and optimize the related code at the
same time.
Reviewers: Ken Huang [email protected], PoAn Yang
[email protected], Chia-Ping Tsai [email protected]