KAFKA-19151: docs: clarify that flush.ms requires log.flush.scheduler.interval.ms config #19479
Conversation
…iggered by log.flush.scheduler.interval.ms
| "this and use replication for durability and allow the operating system's background " + | ||
| "we would fsync after 1000 ms had passed. Note that this setting depends on the broker-level " + | ||
| "configuration \"log.flush.scheduler.interval.ms\", which controls how frequently the flush check occurs. " + | ||
| "If \"log.flush.scheduler.interval.ms\" is not configured, the topic config \"flush.ms\" will not be triggered. " + |
There was a problem hiding this comment.
nit: use <code></code> instead, so we can have code block for configuration.
Example:
There was a problem hiding this comment.
"If "log.flush.scheduler.interval.ms" is not configured, the topic config "flush.ms" will not be triggered. "
Maybe we can remove this as the remaining docs is good enough
There was a problem hiding this comment.
We can also use the LOG_FLUSH_SCHEDULER_INTERVAL_MS_CONFIG and FLUSH_MS_CONFIG constants instead of hardcoding the strings.
There was a problem hiding this comment.
@m1a2st The LOG_FLUSH_SCHEDULER_INTERVAL_MS_CONFIG is in org.apache.kafka.server.config.ServerLogConfigs. It already imported TopicConfig. I don't think we can import the ServerLogConfigs configuration in TopicConfig.
There was a problem hiding this comment.
The
LOG_FLUSH_SCHEDULER_INTERVAL_MS_CONFIGis inorg.apache.kafka.server.config.ServerLogConfigs
Thanks, but FLUSH_MS_CONFIG can update.
There was a problem hiding this comment.
@yunchipang: Thanks for the patch.
Please provide a screenshot of your patch if it is related to documentation.
You can find the instructions in the readme of https://github.com/apache/kafka-site
| "this and use replication for durability and allow the operating system's background " + | ||
| "we would fsync after 1000 ms had passed. Note that this setting depends on the broker-level " + | ||
| "configuration \"log.flush.scheduler.interval.ms\", which controls how frequently the flush check occurs. " + | ||
| "If \"log.flush.scheduler.interval.ms\" is not configured, the topic config \"flush.ms\" will not be triggered. " + |
|
@chia7712 @FrankYang0529 @frankvicky @m1a2st thanks y'all for reviewing. i have pushed the changes, please find the screenshot of the patch below. one newbie question, do i raise a PR in kafka-site repo after this patch is merged? |
Enhanced docs of
flush.msto remind users the flush is triggered bylog.flush.scheduler.interval.ms.Reviewers: @chia7712