MINOR: Update GroupCoordinator interface to use AuthorizableRequestContext instead of RequestContext #19485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntext instead of RequestContext
dajac
commented
Apr 16, 2025
dajac
commented
Apr 16, 2025
rajinisivaram
approved these changes
Apr 16, 2025
There was a problem hiding this comment.
@dajac Thanks for the PR, LGTM. Just left one minor comment.
rreddy-22
pushed a commit
to rreddy-22/kafka-rreddy
that referenced
this pull request
Apr 21, 2025
…ntext instead of RequestContext (apache#19485) This patch updates the `GroupCoordinator` interface to use `AuthorizableRequestContext` instead of using `RequestContext`. It makes the interface more generic. The only downside is that the request version in `AuthorizableRequestContext` is an `int` instead of a `short` so we had to adapt it in a few places. We opted for using `int` directly wherever possible. Reviewers: Chia-Ping Tsai <[email protected]>, Rajini Sivaram <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the
GroupCoordinatorinterface to useAuthorizableRequestContextinstead of usingRequestContext. It makesthe interface more generic. The only downside is that the request
version in
AuthorizableRequestContextis anintinstead of ashortso we had to adapt it in a few places. We opted for using
intdirectlywherever possible.
Reviewers: Chia-Ping Tsai [email protected], Rajini Sivaram
[email protected]