KAFKA-19139 Plugin#wrapInstance should use LinkedHashMap instead of Map #19519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
|
Good. Using LinkedHashMap makes sense here to ensure consistent tag ordering and avoid duplicate time series in metrics backends. The trade-off is acceptable since this is not on a performance-critical path. |
frankvicky
reviewed
Apr 22, 2025
There was a problem hiding this comment.
@m1a2st: Thanks for the patch.
Could you please check the modified files and eliminate the double brace initialization?
Comment on lines
3749
to
3751
| private static final LinkedHashMap<String, String> TAGS = new LinkedHashMap<>() {{ | ||
| put("k", "v"); | ||
| }}; |
There was a problem hiding this comment.
nit: Could we use a static block instead of double brace initialization?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There will be an update to the PluginMetrics#metricName method: the type
of the tags parameter will be changed
from Map to LinkedHashMap.
This change is necessary because the order of metric tags is important
distinct ones by the metrics backend
consistency, we should follow the same approach here.