KAFKA-19185: add logs #19538
Open
KAFKA-19185: add logs #19538
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
kirktrue
reviewed
Apr 23, 2025
There was a problem hiding this comment.
Thanks for the PR @aliehsaeedii!
NetworkClient's request and response handlers log messages with the API key (i.e. FETCH) and the correlation ID. Admittedly all requests and responses are logged, so it would require some filtering. Logging this information at INFO level would be very noisy, IMO.
mjsax
reviewed
Apr 23, 2025
| @@ -131,6 +131,7 @@ public RequestFuture<ClientResponse> send(Node node, | |||
| ClientRequest clientRequest = client.newClientRequest(node.idString(), requestBuilder, now, true, | |||
| requestTimeoutMs, completionHandler); | |||
| unsent.put(node, clientRequest); | |||
| log.info("Generated FETCH with correlation id {}.", clientRequest.correlationId()); | |||
There was a problem hiding this comment.
Logging every request at INFO level, does sound very chatty. I would believe that per-request logging would even be too chatty for DEBUG, and we should make it TRACE instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at enhancing logging in
Consumerrequest/response as follows: