Skip to content

Refactored DescribeTopicPartitionsRequestHandler: Improve readability and add code documentation #19636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: trunk
Choose a base branch
from
Open

Refactored DescribeTopicPartitionsRequestHandler: Improve readability and add code documentation #19636

wants to merge 19 commits into from

Conversation

keemsisi
Copy link

@keemsisi keemsisi commented May 4, 2025

Refactor DescribeTopicPartitionsRequestHandler: Improve readability and add code documentation

Changes:

  • Improved variable naming for better clarity.
  • Added detailed inline comments
  • Refactored some sections of the code for improved readability (e.g., combining logical blocks).
  • Added JavaDoc-style documentation to key methods explaining parameters, return values, and functionality.

integral1 added 19 commits May 4, 2025 19:35
@integral1
Refactor DescribeTopicPartitionsRequestHandler: Improve readability a…
f1d3bf3 
…nd add code documentation
@integral1
update the describeTopicPartitionsResponseTopic method
fef5450
@integral1
update on cursor validation
7a1fc70
@integral1
update on cursor validation
a9ff59e
@integral1
update on cursor validation
1f17a3b
@integral1
added final to varibles that should not change in the method
d875135
@integral1
cleanup code with stylesheet standard
8dbc97b
@integral1
cleanup code with stylesheet standard
e6f5f3c
@integral1
cleanup code with stylesheet standard
280cb54
@integral1
cleanup code with stylesheet standard
0606a8f
@integral1
cleanup code with stylesheet standard
e19f9f8
@integral1
cleanup code with stylesheet standard
af858dd
@integral1
added final to varibles that should not change in the method
668acf4
@integral1
cleanup code with stylesheet standard
6e9c7b3
@integral1
cleanup code with stylesheet standard
2b4bbfe
@integral1
update on vars and method parameters
6ac7917
@integral1
update on vars and method parameters
b485fee
@integral1
update on vars and method parameters
9a44350
@integral1
update on vars and method parameters
768c82d
@github-actions github-actions bot added triage PRs from the community core Kafka Broker labels May 4, 2025
@github-actions GitHub Actions
Copy link

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core Kafka Broker needs-attention triage PRs from the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keemsisi @integral1