KAFKA-18687: Setting the subscriptionMetadata during conversion to consumer group #19790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajac
added
KIP-848
dongnuo123
commented
May 23, 2025
Comment on lines
-2488
to
-2489
| // Top level error will equal to the first partition level error | ||
| assertFutureThrows(classOf[GroupSubscribedToTopicException], offsetDeleteResult.all()) |
There was a problem hiding this comment.
Removed it because offsetDeleteResult.all() throws the first exception it sees in the result topicPartition map but the sequence of the entries is not deterministic
test_topic-0 --> GroupSubscribedToTopicException
foo-0 --> UnknownTopicOrPartitionException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a consumer protocol static member replaces an existing member in a
classic group, it's not necessary to recompute the assignment. However,
it happens anyway.
In
ConsumerGroup.fromClassicGroup,
we don't set the group's subscriptionMetadata. Later in the consumer
group heartbeat, we call
updateSubscriptionMetadata,
which notices that the group's subscriptionMetadata needs an
update
and bumps the epoch. Since the epoch is bumped, we recompute the
assignment.
As a fix, this patch sets the subscriptionMetadata in
ConsumerGroup.fromClassicGroup.