KAFKA-19271: allow intercepting internal method call #19832
+28
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow intercepting the internal subscribe call to the async-consumer, we need to extend ConsumerWrapper interface accordingly, instead of returning the wrapped async-consumer back to the KS runtime.
lucasbru
reviewed
May 28, 2025
| @@ -3926,38 +3925,6 @@ t2p1, new PartitionInfo(t2p1.topic(), t2p1.partition(), null, new Node[0], new N | |||
| ); | |||
| } | |||
|
|
|||
| @ParameterizedTest | |||
There was a problem hiding this comment.
Why have you removed these tests?
There was a problem hiding this comment.
This PR removes public AsyncKafkaConsumer<byte[], byte[]> consumer() which is not needed any longer, but the test rely on it.
lucasbru
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow intercepting the internal subscribe call to the async-consumer,
we need to extend ConsumerWrapper interface accordingly, instead of
returning the wrapped async-consumer back to the KS runtime.