Skip to content

Conversation

@samarth-ksolves
Copy link
Contributor

This PR updated the running-app.html to:

  1. Add missing documentation for Kafka Streams listeners and callbacks.
  2. Current docs do not explain or list the available listeners, making it hard for developers (especially beginners) to use them.
  3. Introduce a new section in Kafka Streams docs covering all supported listeners/callbacks like uncaught-exception-handler, state-restore-listener, state-listener, etc.
  4. Provide short explanations and practical use cases for each listener/callback.

@github-actions github-actions bot added triage PRs from the community docs small Small PRs labels Aug 28, 2025
@mjsax mjsax added ci-approved and removed triage PRs from the community labels Sep 2, 2025
@AndrewJSchofield AndrewJSchofield closed this pull request by merging all changes into apache:trunk in dbe9d34 Sep 23, 2025
@abhi-ksolves
Copy link
Contributor

abhi-ksolves commented Sep 25, 2025

Hi @AndrewJSchofield / @mjsax,

This PR is not valid as it contains changes in the trunk branch, which conflicts with other PRs. We decided to reset the trunk.

The actual PR can be found here: #20589

Created by @samarth-ksolves

@mjsax
Copy link
Member

mjsax commented Sep 28, 2025

@abhi-ksolves @AndrewJSchofield -- I am somewhat confused.

AndrewJSchofield closed this pull request by merging all changes into apache:trunk in dbe9d34 last week

What is this supposed to mean? I cannot find any commit for this PR in trunk branch. Why is this PR marked as merged?

This PR also says on top

0 commits merged into apache:trunk from ksolves:trunk last week

And has zero commits. Any idea why?

@abhi-ksolves
Copy link
Contributor

abhi-ksolves commented Sep 29, 2025

@mjsax Let me clarify the confusion.

The usual practice is that whenever we need to work on a ticket, we create a new branch from trunk (for example, Kafka-), apply our changes there, and then open a PR from that branch to Kafka/trunk.

In our case, @samarth-ksolves and I share the same forked Kafka repository for contributions. What happened here is that @samarth-ksolves initially created a PR directly from the forked trunk branch to Kafka/trunk.

At that point, you saw 1 file change with more than 0 commits.

On my side, the unmerged commits in our forked trunk branch caused issues when I tried to create a different branch that inherited the commits from this PR. To fix this, I reset our forked trunk, which in turn resulted in this PR showing 0 commits and 0 file changes.

At this point, commits are 0 and file changes are 0.

After this whole event, @AndrewJSchofield merged the PR.

@AndrewJSchofield
Copy link
Member

I merged #20385.

@abhi-ksolves
Copy link
Contributor

Hi @AndrewJSchofield
Can you please check #20589

@mjsax
Copy link
Member

mjsax commented Sep 29, 2025

Ah. Thanks for clarifying :)

@mjsax
Copy link
Member

mjsax commented Sep 29, 2025

@AndrewJSchofield How is #20385 related? Seems to be some unrelated PR?

@AndrewJSchofield
Copy link
Member

@AndrewJSchofield How is #20385 related? Seems to be some unrelated PR?

Just some git confusion I think. They're not related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants