KAFKA-19734 Updating the docs as a follow up to #20766 #20804
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjsax
reviewed
Nov 3, 2025
docs/ops.html
Outdated
| <td>thread-state</td> | ||
| <td>The state of the thread as a number (<code>ordinal()</code> of the corresponding enum).</td> | ||
| <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+),process-id=([-.\w]+)</td> | ||
| <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+),process-id=([-.\w]+),application-id=([-.\w]+)</td> |
There was a problem hiding this comment.
Seems we only add the new tag to client-state but not to thead-state -- so this change seems not to apply.
There was a problem hiding this comment.
As a follow-up to this comment, the thread-id will already have the application-id embedded in it.
mjsax
added
streams
kip
bbejeck
reviewed
Nov 4, 2025
There was a problem hiding this comment.
Thanks for the PR @gensericghiro, overall lgtm once we address the outstanding comment.
mjsax
reviewed
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updating the docs for the client state metric as a follow up to #20766