KAFKA-16366: Refactor KTable source optimization #20968
Open
+164
−35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
DSL's optimization logic (reusing the input topic as the changelog) to leverage the publicTopology#addReadOnlyStateStoreAPI introduced in KIP-813, replacing the previous usage of internal builder methods.Key Changes:
TableSourceNodeaddSource,addProcessor,connectSourceStoreAndTopic) with a call totopologyBuilder.addReadOnlyStateStore.InternalTopologyBuilder:addReadOnlyStateStoremethod accepting aProcessorSupplierwith wildcard output types(?, ?).addReadOnlyStateStoreenforcesVoid, Voidoutput types. However, theDSL'sKTableSourceneeds to forward records downstream (emitting K, Change). The internal overload allows theDSLto reuse the "read-only" wiring logic while maintaining its forwarding behavior.TopologyTest#whenKTableSourceIsOptimizedThenTopologyShouldBeSerialPipeline- Verifies that the generated topology description remains identical to the pre-refactoring structure, ensuring strict backward compatibility.TopologyTest#whenKTableSourceIsOptimizedThenItsStateStoreShouldNotLog- Confirms that the optimization is correctly applied (changelog logging is disabled).Result