MINOR: Add character range support to Glob patterns in Kafka shell #21355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing @return description in ProducerManager.publishMessage() - Add missing @return description in RemoteLogMetadataCache.listAllRemoteLogSegments() - Add missing @throws description in LogDirFailureChannel.takeNextOfflineLogDir() All Javadoc tags now have proper descriptions following Apache Kafka documentation standards.
Contributor
Author
|
@halorgium , @astubbs , @amir , @alexism |
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements character range support (e.g.,
[a-z],[0-9],[abc]) for glob pattern matching within the Kafka shell module. It addresses a long-standingTODOcomment inGlobComponent.java.The implementation includes:
!and^(e.g.,[!a-z]).[a\-z]).]as the first character in a set (e.g.,[]abc]).Additionally, the
toRegularExpressionmethod was refactored to extract bracket and escape handling into separate private methods. This was done to reduce the NPath complexity from 1020 to within the project's Checkstyle limit (500).Testing Strategy
The changes were verified using unit tests in
GlobComponentTest.java.A new set of comprehensive test cases was added to cover:
*and?).All tests were executed and passed on a local environment using OpenJDK 21.
License
I state that the contribution is my original work and that I license the work to the project under the project's open source license.