Skip to content

Conversation

@yangfeng123456
Copy link

What’s the problem:

  • When commitOffsetsAsync fails, the client callback sometimes doesn’t get called.
    This can leave clients hanging, not knowing their commit actually failed.

What’s the fix:

  • In doCommitOffsetsAsync.onFailure, call the provided OffsetCommitCallback immediately if it’s not null.
  • This ensures clients are always notified about commit failures, fixing KAFKA-10489.

Things to note:

  • Rare edge case: if a rebalance happens while a commit is in flight, the callback might be triggered twice.
  • Overall, this is safer than the current behavior where clients might never hear about the failure.

@github-actions github-actions bot added triage PRs from the community consumer clients small Small PRs labels Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clients consumer small Small PRs triage PRs from the community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant