-
Notifications
You must be signed in to change notification settings - Fork 14.9k
KAFKA-16262: Add IQv2 to Kafka Streams documentation #21367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
if a specific Serde is used earlier in the code, it will reuse that one instead of looking at the global defaults.
1. Added a new file config/streams.properties. 2. This file includes most of the essential configuraions with their respective defaulf values. 3. Any Developer can use this file as a base template and override the specific configuration as per their requirements.
1. Added a new file config/streams.properties. 2. This file includes most of the essential configuraions with their respective defaulf values. 3. Any Developer can use this file as a base template and override the specific configuration as per their requirement.
1. Added a new file config/streams.properties. 2. This file includes most of the essential configurations with their respective default values. 3. Any Developer can use this file as a base template and override the specific configuration as per their requirement.
1. Added a new file config/streams.properties. 2. This file includes most of the essential configurations with their respective default values. 3. Any Developer can use this file as a base template and override the specific configuration as per their requirement.
1. Added a new file config/streams.properties. 2. This file includes most of the essential configurations with their respective default values. 3. Any Developer can use this file as a base template and override the specific configuration as per their requirement.
This reverts commit 6196acf.
This reverts commit aa79e13. # Conflicts: # config/streams.properties
1. Added a new file config/streams.properties. 2. This file includes most of the essential configurations with their respective default values. 3. Any Developer can use this file as a base template and override the specific configuration as per their requirement.
This reverts commit 71473d1.
Documented Interactive Queries v2 in the Streams Interactive Queries developer guide. The update positions IQv2 as the new API, includes a basic usage example, and clearly states that the API is not yet feature complete, while keeping IQv1 documented as the legacy API.
Signed-off-by: mshijin-ksolves <[email protected]>
|
@aliehsaeedii for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mshijin-ksolves for bridging the gap. I made the first round of review.
| IQv2 improves API safety, extensibility, and error handling by: | ||
|
|
||
| - Decoupling query definition from store internals | ||
| - Returning structured query results instead of throwing exceptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add returns metadata (prtitions) beside query results?
|
|
||
| ``` | ||
| // Build a query to fetch the value for a specific key | ||
| StateQueryRequest<KeyQuery<String, Long>> request = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you run this test? It needs to be StateQueryRequest<Long>
|
|
||
| 3. **Read the Result** | ||
| ``` | ||
| if (result.hasFailures()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StateQueryResult (result) does not provide these methods. First obtain a QueryResult object by calling one of the getPartitions... or getGlobalResult methods, and then invoke the methods on that object. Please verify this with a real example before posting the code. Thanks.
| System.out.println("Query result: " + value); | ||
| } | ||
|
|
||
| ## Comparison : Interactive Queries (IQv1) and (IQv2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove white-space before :
Could it be Comparison of IQv1 and IQv2?
Description: This change updates the documentation to introduce Interactive Queries v2 (IQv2) as a new API and improve user awareness, despite it currently being feature-incomplete.
The documentation now includes:
Please review the changes and provide feedback or suggestions for further improvements.
Ticket link:- https://issues.apache.org/jira/browse/KAFKA-16262