KAFKA-20064: Made PartitionLeaderCache thread safe. (#21335) #21374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduced a new class - PartitionLeaderCache * Changed the usage of the cache to make calls atomic(e.g. getting cached and non-cached values as one call instead of two, deleting cached values as one call, not one by one) * Added an integration test that tests the concurrent access of the cache Reviewers: Andrew Schofield <[email protected]>
Contributor
Author
|
the original PR: #21335 |
Contributor
|
Approved the CI flow. Once it's green, I think it's good to be merged as it has been reviewed already. |
Member
@Nikita-Shupletsov could you please fix the error? |
Member
|
@Nikita-Shupletsov Maybe we could use dynamic call to overcome the access scope limit. |
Contributor
Author
|
@chia7712 taking a look |
Contributor
Author
|
4.0 branch doesn't have clients/clients-integration-tests module, so I removed the test. cherry pick automatically moved the class to core, which is not correct, imo, as it is for scala |
Member
Please check previous comment (#21374 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: Andrew Schofield [email protected]